Github user liancheng commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13704#discussion_r72077898
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
 ---
    @@ -1441,6 +1441,12 @@ object PushPredicateThroughJoin extends 
Rule[LogicalPlan] with PredicateHelper {
     object SimplifyCasts extends Rule[LogicalPlan] {
       def apply(plan: LogicalPlan): LogicalPlan = plan transformAllExpressions 
{
         case Cast(e, dataType) if e.dataType == dataType => e
    +    case c @ Cast(e, dataType) => (e.dataType, dataType) match {
    --- End diff --
    
    As long as we only do this kind of casting in the case mentioned above, it 
should be safe. But currently I'm not sure whether that is true.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to