Github user viirya commented on a diff in the pull request:
https://github.com/apache/spark/pull/14296#discussion_r72177317
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1207,6 +1207,17 @@ class Analyzer(
val alias = Alias(ae, ae.toString)()
aggregateExpressions += alias
alias.toAttribute
+ // Replacing [[NamedExpression]] causes the error on
[[Grouping]] because the
+ // grouping column will be new attribute created by adding
additional [[Alias]].
+ // So we can't find the grouping column and replace it in
the rule
+ // [[ResolveGroupingAnalytics]].
+ case ne: NamedExpression => ne
+ // Grouping functions are handled in the rule
[[ResolveGroupingAnalytics]].
+ case e: Expression if grouping.exists(_.semanticEquals(e)) &&
+ !ResolveGroupingAnalytics.hasGroupingFunction(e) =>
--- End diff --
Yes. SQLQuerySuite has test for with grouping function in HAVING.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
