Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/14132#discussion_r72181762
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1774,6 +1775,49 @@ class Analyzer(
}
/**
+ * Substitute Hints.
+ * - BROADCAST/BROADCASTJOIN/MAPJOIN match the closest table with the
given name parameters.
+ *
+ * This rule substitutes `UnresolvedRelation`s in `Substitute` batch
before `ResolveRelations`
+ * rule is applied. Here are two reasons.
+ * - To support `MetastoreRelation` in Hive module.
+ * - To reduce the effect of `Hint` on the other rules.
+ *
+ * After this rule, it is guaranteed that there exists no unknown `Hint`
in the plan.
+ * All new `Hint`s should be transformed into concrete Hint classes
`BroadcastHint` here.
+ */
+ object SubstituteHints extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case logical: LogicalPlan => logical transformDown {
+ case h @ Hint(name, parameters, child)
+ if Seq("BROADCAST", "BROADCASTJOIN",
"MAPJOIN").contains(name.toUpperCase) =>
+ var resolvedChild = child
+
+ for (table <- parameters) {
+ var stop = false
+ resolvedChild = resolvedChild.transformDown {
--- End diff --
You probably want to look at older versions of Hive. For example, 0.10.
After https://issues.apache.org/jira/browse/HIVE-3784, Hive does not really use
map join hint.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
