Github user mgummelt commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14175#discussion_r72308905
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosCoarseGrainedSchedulerBackend.scala
 ---
    @@ -552,7 +552,12 @@ private[spark] class 
MesosCoarseGrainedSchedulerBackend(
           taskId: String,
           reason: String): Unit = {
         stateLock.synchronized {
    -      removeExecutor(taskId, SlaveLost(reason))
    +      // Do not call removeExecutor() after this scheduler backend was 
stopped because
    --- End diff --
    
    I'm fine with this going in as-is just to the get the problem solved, but I 
do still think that classes should try to ensure that their public methods are 
callable w/o state consideration, so I would have rather we fixed this in the 
parent.  Let's try to maintain that going forward.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to