Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14371#discussion_r72315301
  
    --- Diff: 
core/src/main/scala/org/apache/spark/rdd/ReliableCheckpointRDD.scala ---
    @@ -240,7 +248,7 @@ private[spark] object ReliableCheckpointRDD extends 
Logging {
           val bufferSize = sc.conf.getInt("spark.buffer.size", 65536)
           val partitionerFilePath = new Path(checkpointDirPath, 
checkpointPartitionerFileName)
           val fs = partitionerFilePath.getFileSystem(sc.hadoopConfiguration)
    -      if (fs.exists(partitionerFilePath)) {
    +      try {
    --- End diff --
    
    I suppose this has the small disadvantage of putting more code inside a try 
block that isn't intended to handle exceptions from the rest. Can the other 
code be moved after the block, and short-circuit and return None in the 
exception block?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to