Github user aarondav commented on a diff in the pull request:
https://github.com/apache/spark/pull/1967#discussion_r16299399
--- Diff:
core/src/main/scala/org/apache/spark/deploy/worker/CommandUtils.scala ---
@@ -73,8 +73,17 @@ object CommandUtils extends Logging {
extraEnvironment = command.environment)
val userClassPath = command.classPathEntries ++ Seq(classPath)
- Seq("-cp",
userClassPath.filterNot(_.isEmpty).mkString(File.pathSeparator)) ++
- permGenOpt ++ libraryOpts ++ workerLocalOpts ++ command.javaOpts ++
memoryOpts
+ val runner = getEnv("JAVA_HOME", command).map(_ +
"/bin/java").getOrElse("java")
--- End diff --
Is all this code and munging in case JAVA_HOME is not the same Java as the
Worker was started with? Otherwise it seems we could just do
`sys.env("java.version")`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
