Github user yhuai commented on a diff in the pull request:
https://github.com/apache/spark/pull/12645#discussion_r72834461
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveStrategies.scala ---
@@ -83,27 +83,4 @@ private[hive] trait HiveStrategies {
Nil
}
}
-
- object HiveDDLStrategy extends Strategy {
- def apply(plan: LogicalPlan): Seq[SparkPlan] = plan match {
- case CreateTableUsing(
- tableIdent, userSpecifiedSchema, provider, false, opts,
allowExisting, managedIfNoPath) =>
- val cmd =
- CreateMetastoreDataSource(
- tableIdent, userSpecifiedSchema, provider, opts,
allowExisting, managedIfNoPath)
- ExecutedCommandExec(cmd) :: Nil
-
- case c: CreateTableUsingAsSelect if c.temporary =>
- val cmd = CreateTempTableUsingAsSelect(
- c.tableIdent, c.provider, c.partitionColumns, c.mode, c.options,
c.child)
- ExecutedCommandExec(cmd) :: Nil
-
- case c: CreateTableUsingAsSelect =>
--- End diff --
1.6 works because it internally uses insertInto. But, if we change it back
it will break the semantic of `saveAsTable` (this method uses by-name
resolution instead of using by-position resolution used by insertInto).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
