Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14419#discussion_r72894773
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetCompatibilityTest.scala
 ---
    @@ -119,8 +119,19 @@ private[sql] object ParquetCompatibilityTest {
           metadata: Map[String, String],
           recordWriters: (RecordConsumer => Unit)*): Unit = {
         val messageType = MessageTypeParser.parseMessageType(schema)
    -    val writeSupport = new DirectWriteSupport(messageType, metadata)
    -    val parquetWriter = new ParquetWriter[RecordConsumer => Unit](new 
Path(path), writeSupport)
    +    val testWriteSupport = new DirectWriteSupport(messageType, metadata)
    --- End diff --
    
    can you explain what's going on here? This seems like pretty complicated.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to