Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14425#discussion_r72895124
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/FileSourceStrategySuite.scala
 ---
    @@ -408,6 +408,39 @@ class FileSourceStrategySuite extends QueryTest with 
SharedSQLContext with Predi
         }
       }
     
    +  test("[SPARK-16818] partition pruned file scans implement sameResult 
correctly") {
    +    withTempPath { path =>
    +      val tempDir = path.getCanonicalPath
    +      spark.range(100)
    +        .selectExpr("id", "id as b")
    +        .write
    +        .partitionBy("id")
    +        .parquet(tempDir)
    +      val df = spark.read.parquet(tempDir)
    +      def getPlan(df: DataFrame): SparkPlan = {
    +        df.queryExecution.executedPlan
    +      }
    +      assert(getPlan(df.where("id = 2")).sameResult(getPlan(df.where("id = 
2"))))
    --- End diff --
    
    did you verify this would fail without your patch?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to