Github user ankurdave commented on the pull request:
https://github.com/apache/spark/pull/1903#issuecomment-52378594
This isn't quite the right approach, since the call to reduceByKey will
result in two rounds of communication and hash aggregations (in reduceByKey and
copartitionWithVertices) when only one is necessary. It would be better to add
a ShippableVertexPartition constructor that takes a mergeFunc, then just pass
the mergeFunc from here into that constructor.
Also, the capitalization in `VD1` and `VD2` suggests that they are type
parameters when they are actually function parameters -- they should probably
just be `a` and `b`.
I can make these changes this weekend if you like.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
