Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14430#discussion_r72910955
--- Diff:
sql/hive/compatibility/src/test/scala/org/apache/spark/sql/hive/execution/HiveWindowFunctionQuerySuite.scala
---
@@ -89,15 +89,6 @@ class HiveWindowFunctionQuerySuite extends
HiveComparisonTest with BeforeAndAfte
s"""
|LOAD DATA LOCAL INPATH '$testData2' overwrite into table over1k
""".stripMargin)
-
- // The following settings are used for generating golden files with
Hive.
- // We have to use kryo to correctly let Hive serialize plans with
window functions.
- // This is used to generate golden files.
- sql("set hive.plan.serialization.format=kryo")
- // Explicitly set fs to local fs.
- sql(s"set fs.default.name=file://$testTempDir/")
- // Ask Hive to run jobs in-process as a single map and reduce task.
- sql("set mapred.job.tracker=local")
--- End diff --
These statements are dead code. If we really need, we have to use the
`runSqlHive` API of `HiveClient`. Since it does not cause errors, I remove
them.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
