Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14355#discussion_r72912491
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -280,6 +267,32 @@ trait CheckAnalysis extends PredicateHelper {
case p if
p.expressions.exists(PredicateSubquery.hasPredicateSubquery) =>
failAnalysis(s"Predicate sub-queries can only be used in a
Filter: $p")
+ case _: Union | _: SetOperation if operator.children.length > 1
=>
+ def dataTypes(plan: LogicalPlan): Seq[DataType] =
plan.output.map(_.dataType)
+ def ordinalTable(i: Int): String = (if (i == 0) "second" else
(i + 2) + "th") + " table"
+ val ref = dataTypes(operator.children.head)
+ operator.children.tail.zipWithIndex.foreach { case (child, ti)
=>
+ // Check the number of columns
+ if (child.output.length != ref.length) {
+ failAnalysis(
+ s"""
+ |${operator.nodeName} can only be performed on tables
with the same number
+ |of columns, but the first table has ${ref.length}
columns and
+ |the ${ordinalTable(ti)} has ${child.output.length}
columns
+ """.stripMargin.replace("\n", " ").trim())
+ }
+ // Check if the data types match.
+ dataTypes(child).zip(ref).zipWithIndex.foreach { case ((dt1,
dt2), ci) =>
+ if (dt1 != dt2) {
+ failAnalysis(
+ s"""
+ |${operator.nodeName} can only be performed on
tables with the compatible
+ |column types. $dt1 <> $dt2 at ${ci + 1}th column of
${ordinalTable(ti)}
--- End diff --
NIT:`${ci + th}` can also apply the first/second column. Also `column of`
should end with `the`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
