Github user jiangxb1987 commented on a diff in the pull request:
https://github.com/apache/spark/pull/13893#discussion_r73176693
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/planning/patterns.scala
---
@@ -64,10 +64,17 @@ object PhysicalOperation extends PredicateHelper {
val substitutedFields =
fields.map(substitute(aliases)).asInstanceOf[Seq[NamedExpression]]
(Some(substitutedFields), filters, other,
collectAliases(substitutedFields))
- case Filter(condition, child) if condition.deterministic =>
+ case Filter(condition, child) =>
val (fields, filters, other, aliases) =
collectProjectsAndFilters(child)
- val substitutedCondition = substitute(aliases)(condition)
- (fields, filters ++
splitConjunctivePredicates(substitutedCondition), other, aliases)
+
+ // Deterministic parts of filter condition placed before
non-deterministic predicates could
+ // be pushed down safely.
+ val (pushDown, rest) =
--- End diff --
Thank you @cloud-fan for pointing that out, I realized my previous thoughts
were wrong. I fully agree with @liancheng 's improvement idea. Will update
related code as well as new testcases tomorrow.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
