Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14456#discussion_r73256998
--- Diff: python/pyspark/ml/tuning.py ---
@@ -234,7 +234,7 @@ def _fit(self, dataset):
model = est.fit(train, epm[j])
# TODO: duplicate evaluator to take extra params from input
metric = eva.evaluate(model.transform(validation, epm[j]))
- metrics[j] += metric
+ metrics[j] += metric/nFolds
--- End diff --
OK looks fine actually. Would it be possible to add a little bit to the
test above this to demonstrate that the result is correct now? just testing the
value of the first element of metrics for example.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
