GitHub user viirya opened a pull request:

    https://github.com/apache/spark/pull/1985

    [SPARK-3077] fix unnecessarily removing sendingConnection when closing 
connections

    Currently in `ConnectionManager`, when a `ReceivingConnection` is closing, 
the corresponding `SendingConnection` would be removed twice. It causes 
unnecessary errors when removing `sendingConnectionManagerId` from 
`connectionsById`. There are also redundant codes in the implementation.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/viirya/spark-1 fix_removing_connection

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/1985.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1985
    
----
commit a637ea9cd72136794991b888b84cc27fa147e943
Author: Liang-Chi Hsieh <vii...@gmail.com>
Date:   2014-08-16T14:26:57Z

    not necessary to remove sendingConnection twice.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to