Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14476#discussion_r73291143
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/catalog/ExternalCatalog.scala
---
@@ -82,7 +82,7 @@ abstract class ExternalCatalog {
* Note: If the underlying implementation does not support altering a
certain field,
* this becomes a no-op.
*/
- def alterTable(db: String, tableDefinition: CatalogTable): Unit
+ def alterTable(tableDefinition: CatalogTable): Unit
--- End diff --
Logically a table is referenced by a pair of `dbName` and `tableName`. If
we have a table `db1.tbl1`, and then alter table `db2.tbl1`, the semantic is
not moving `tbl1` from `db1` to `db2`, but alter a nonexistent table
`db2.tabl1`. For ALTER TABLE, I think there is no such a concept about `moving
database`. what do you think?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
