Github user jaceklaskowski commented on a diff in the pull request:
https://github.com/apache/spark/pull/14435#discussion_r73332522
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/logical/basicLogicalOperators.scala
---
@@ -53,6 +53,40 @@ case class Project(projectList: Seq[NamedExpression],
child: LogicalPlan) extend
override def validConstraints: Set[Expression] =
child.constraints.union(getAliasedConstraints(projectList))
+
+ override def sql: String = {
+ if (projectList.exists(expr => expr.find(e =>
e.isInstanceOf[NonSQLExpression]).isDefined)) {
--- End diff --
This `if` is overly complex and forces a reader to read the expression
inside-out (not left to right).
I can't propose anything better than beg for a boolean val with the entire
boolean condition on a separate line.
WDYT?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
