Github user viirya commented on a diff in the pull request:

    https://github.com/apache/spark/pull/13701#discussion_r73333937
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/execution/datasources/parquet/ParquetFilterSuite.scala
 ---
    @@ -527,4 +536,43 @@ class ParquetFilterSuite extends QueryTest with 
ParquetTest with SharedSQLContex
           assert(df.filter("_1 IS NOT NULL").count() === 4)
         }
       }
    +
    +  test("Fiters should be pushed down for vectorized Parquet reader at row 
group level") {
    --- End diff --
    
    We already have test for the pushed down filters for ParquetRecordReader. 
But it is at individual record level. If you mean row group level, because 
ParquetRecordReader doesn't expose a count for the row group, I think we can't 
check if the filter is pushed down. Besides, it seems to be the functionality 
of ParquetRecordReader, and I think it should be unit test in parquet project.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to