Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14467#discussion_r73408145
--- Diff: core/src/main/scala/org/apache/spark/api/python/PythonRDD.scala
---
@@ -889,21 +891,40 @@ private class PythonAccumulatorParam(@transient
private val serverHost: String,
socket
}
- override def zero(value: JList[Array[Byte]]): JList[Array[Byte]] = new
JArrayList
+ override def reset(): Unit = {
+ this._acc = new JArrayList[Array[Byte]]
+ }
+
+ override def isZero: Boolean = {
+ this._acc.isEmpty
+ }
- override def addInPlace(val1: JList[Array[Byte]], val2:
JList[Array[Byte]])
- : JList[Array[Byte]] = synchronized {
+ override def copy(): PythonAccumulatorV2 = {
+ val newAcc = new PythonAccumulatorV2(serverHost, serverPort)
+ newAcc._acc = this._acc
+ newAcc
+ }
+
+ // This happens on the worker node, where we just want to remember all
the updates
+ override def add(val2: JList[Array[Byte]]): Unit = synchronized {
--- End diff --
OK, could I also suggest synchronizing on _acc instead of the accumulator
too, just to be a little tighter and safer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
