Github user ajbozarth commented on a diff in the pull request:
https://github.com/apache/spark/pull/14484#discussion_r73415554
--- Diff: core/src/main/scala/org/apache/spark/ui/env/EnvironmentPage.scala
---
@@ -25,9 +25,13 @@ import org.apache.spark.ui.{UIUtils, WebUIPage}
private[ui] class EnvironmentPage(parent: EnvironmentTab) extends
WebUIPage("") {
private val listener = parent.listener
+ // Spark Properties (lowercase). Their values will be changed to *****
in WebUI
+ private val propertiesToMask = Set("spark.authenticate.secret")
private def removePass(kv: (String, String)): (String, String) = {
- if (kv._1.toLowerCase.contains("password")) (kv._1, "******") else kv
+ if (kv._1.toLowerCase.contains("password") ||
propertiesToMask.contains(kv._1.toLowerCase)) {
--- End diff --
Are we sure we don't want to mask every property with the word `secret`
like we did with `password`?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
