Github user gatorsmile commented on a diff in the pull request:
https://github.com/apache/spark/pull/14482#discussion_r73461508
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/rules.scala
---
@@ -206,22 +206,22 @@ private[sql] case class PreWriteCheck(conf: SQLConf,
catalog: SessionCatalog)
// The relation in l is not an InsertableRelation.
failAnalysis(s"$l does not allow insertion.")
- case c: CreateTableUsingAsSelect =>
+ case CreateTable(tableDesc, mode, Some(query)) =>
--- End diff --
Previously, this is only applicable to Data Source tables. After this
change, this is also applicable to Create Hive Table As Select. Thus, some
validation might not be right to Hive tables. We have to be careful to check
them one by one.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
