Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/1787#discussion_r16327142
--- Diff: core/src/main/scala/org/apache/spark/rdd/DoubleRDDFunctions.scala
---
@@ -96,6 +96,10 @@ class DoubleRDDFunctions(self: RDD[Double]) extends
Logging with Serializable {
*/
def histogram(bucketCount: Int): Pair[Array[Double], Array[Long]] = {
// Compute the minimum and the maxium
+ def customRange(min: Double, max: Double, steps: Int):
IndexedSeq[Double] = {
+ val span = max - min
--- End diff --
I thought the order of operations would be important to get the result, so
wrote it that way on purpose, but, it's actually fine this way too. I think the
win here is not repeatedly adding 1/steps alone.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
