Github user ericl commented on a diff in the pull request: https://github.com/apache/spark/pull/13152#discussion_r73615142 --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManagerId.scala --- @@ -69,24 +72,39 @@ class BlockManagerId private ( out.writeUTF(executorId_) out.writeUTF(host_) out.writeInt(port_) + out.writeBoolean(topologyInfo_.isDefined) + // if we don't keep topology information, we just write an empty string. + out.writeUTF(topologyInfo_.getOrElse("")) --- End diff -- You can just omit this write if it's missing?
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org