Github user yhuai commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14155#discussion_r73622711
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/internal/HiveSerDe.scala ---
    @@ -42,8 +41,7 @@ object HiveSerDe {
             HiveSerDe(
               inputFormat = 
Option("org.apache.hadoop.hive.ql.io.RCFileInputFormat"),
               outputFormat = 
Option("org.apache.hadoop.hive.ql.io.RCFileOutputFormat"),
    -          serde = Option(conf.getConfString("hive.default.rcfile.serde",
    -            
"org.apache.hadoop.hive.serde2.columnar.LazyBinaryColumnarSerDe"))),
    +          serde = 
Option("org.apache.hadoop.hive.serde2.columnar.LazyBinaryColumnarSerDe")),
    --- End diff --
    
    I think as long as we can read RCFile data serialized with 
LazySimpleColumnarSerDe. We are good. When creating a new RCFile, I think the 
binary serde needs to be used. Btw, we need to a release note to mention this 
change.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to