Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/13950#discussion_r73758964
--- Diff: core/src/main/scala/org/apache/spark/ui/JettyUtils.scala ---
@@ -186,6 +188,66 @@ private[spark] object JettyUtils extends Logging {
contextHandler
}
+ /** Create a handler for proxying request to Workers and Application
Drivers */
+ def createProxyHandler(
+ prefix: String,
+ target: String): ServletContextHandler = {
+ val servlet = new ProxyServlet {
+ override def rewriteTarget(request: HttpServletRequest): String = {
+ val path = request.getRequestURI();
+ if (!path.startsWith(prefix)) return null
+
+ val uri = new StringBuilder(target)
+ if (target.endsWith("/")) uri.setLength(uri.length() - 1)
--- End diff --
Seems like it would be better to normalize `target` and `prefix` before
instantiating the servlet, so that they conform to whatever you expect, and
avoid these extra checks on every invocation of the method.
e.g., make sure `target` does not end with a slash, and `prefix` does.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
