Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14407#discussion_r73761135
--- Diff:
core/src/main/scala/org/apache/spark/deploy/FaultToleranceTest.scala ---
@@ -113,7 +112,7 @@ private object FaultToleranceTest extends App with
Logging {
assertValidClusterState()
killLeader()
- delay(30 seconds)
+ delay(30.seconds)
--- End diff --
Personally I prefer `30 seconds`. I counted 3 non-time-related usages in
your change, so this feels like a lot of churn for not much gain - we could
just fix those and remove the unnecessary imports where postfix ops are not
used.
It'd also help if it were possible to turn these warnings into errors,
since people don't generally pay attention to warnings...
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
