Github user shane-huang commented on a diff in the pull request:

    https://github.com/apache/spark/pull/1907#discussion_r16329942
  
    --- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala 
---
    @@ -86,13 +89,25 @@ private[spark] class BlockManager(
         new TachyonStore(this, tachyonBlockManager)
       }
     
    +  private val useNetty = conf.getBoolean("spark.shuffle.use.netty", false)
    +
    --- End diff --
    
    since useNetty is now a member val, maybe we can change the lines in 
getMultiple() to use this val instead of the original boolean too. Check out 
below lines:
    ...
    getMultiple(){
    ...
    val iter =
          if (conf.getBoolean("spark.shuffle.use.netty", false)) {
            new BlockFetcherIterator.NettyBlockFetcherIterator(this, 
blocksByAddress, serializer,
              readMetrics)
          } else { 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to