Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14526#discussion_r73805425
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/StringFunctionsSuite.scala ---
@@ -95,7 +95,7 @@ class StringFunctionsSuite extends QueryTest with
SharedSQLContext {
}
test("non-matching optional group") {
- val df = Seq("aaaac").toDF("s")
+ val df = Seq(Tuple1("aaaac")).toDF("s")
--- End diff --
OK, I guess that Scala 2.11 has an implicit conversion that Scala 2.10 does
not that would make this conversion automatically, hence the PR builder
succeeded. We could also just add a dummy column in the example, but I suppose
this is the best way to ensure that the fix works in 1.6, and also makes the
test a little more robust. LGTM, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
