Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14530#discussion_r73823171
--- Diff:
core/src/main/scala/org/apache/spark/storage/StorageStatusListener.scala ---
@@ -77,6 +77,18 @@ class StorageStatusListener(conf: SparkConf) extends
SparkListener {
val maxMem = blockManagerAdded.maxMem
val storageStatus = new StorageStatus(blockManagerId, maxMem)
executorIdToStorageStatus(executorId) = storageStatus
+
+ // Try to remove the dead storage status if same executor register
the block manger twice.
+ removeDeadExecutorStorageStatus(executorId)
+ }
+ }
+
+ private def removeDeadExecutorStorageStatus(executorId: String): Unit = {
+ deadExecutorStorageStatus.zipWithIndex.foreach { case (status, index)
=>
--- End diff --
Just commenting on the code, not the logic: isn't this just something like
`deadExecutorStorageStatus.retain(_.blockManagerId.executorId != executorId)`?
I know it does something slightly different, but maybe it's desirable to clear
all such matching statuses. And it's a one-liner that doesn't need a method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
