Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14065#discussion_r73930764
  
    --- Diff: 
yarn/src/main/scala/org/apache/spark/deploy/yarn/security/CredentialUpdater.scala
 ---
    @@ -53,50 +53,58 @@ private[spark] class CredentialUpdater(
           override def run(): Unit = 
Utils.logUncaughtExceptions(updateCredentialsIfRequired())
         }
     
    -  @volatile private var timeOfNextUpdate = 
sparkConf.get(CREDENTIALS_UPDATE_TIME)
    +  /** Start the credentail updater thread periodically to get the 
credentials */
    +  def bootstrap(): Unit = {
    +    val bootstrapTime = sparkConf.get(CREDENTIALS_RENEWAL_TIME)
    +    val remainingTime = bootstrapTime - System.currentTimeMillis()
    +    if (remainingTime <= 0) {
    +      // We just checked for new credentials but none were there, wait a 
minute and retry.
    --- End diff --
    
    This comment is now wrong, since you haven't checked for anything yet.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to