Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14522#discussion_r73981600
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -771,6 +771,10 @@ setGeneric("over", function(x, window) { 
standardGeneric("over") })
     
     ###################### WindowSpec Methods ##########################
     
    +#' @rdname orderBy
    +#' @export
    --- End diff --
    
    hmm, that's interesting. I'm not sure if this is necessary, or if this 
works. I think the purpose of setGeneric would only need this once. By putting 
a @rdname tag it will show up on the Rd file, but I don't think we need to put 
it twice, once in different Rd?



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to