Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74016085
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -82,15 +87,16 @@ NULL
     #' Users can call \code{summary} to print a summary of the fitted model, 
\code{predict} to make
     #' predictions on new data, and \code{write.ml}/\code{read.ml} to 
save/load fitted models.
     #'
    -#' @param data SparkDataFrame for training.
    -#' @param formula A symbolic description of the model to be fitted. 
Currently only a few formula
    +#' @param data a SparkDataFrame for training.
    +#' @param formula a symbolic description of the model to be fitted. 
Currently only a few formula
     #'                operators are supported, including '~', '.', ':', '+', 
and '-'.
    -#' @param family A description of the error distribution and link function 
to be used in the model.
    +#' @param family a description of the error distribution and link function 
to be used in the model.
     #'               This can be a character string naming a family function, 
a family function or
     #'               the result of a call to a family function. Refer R family 
at
     #'               
\url{https://stat.ethz.ch/R-manual/R-devel/library/stats/html/family.html}.
    -#' @param tol Positive convergence tolerance of iterations.
    -#' @param maxIter Integer giving the maximal number of IRLS iterations.
    +#' @param tol positive convergence tolerance of iterations.
    +#' @param maxIter integer giving the maximal number of IRLS iterations.
    +#' @param ... additional arguments passed to the method.
    --- End diff --
    
    there is no `...` here in the signature?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to