Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14534#discussion_r74024410
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/server/SparkSQLOperationManager.scala
---
@@ -39,15 +38,19 @@ private[thriftserver] class SparkSQLOperationManager()
val handleToOperation = ReflectionUtils
.getSuperField[JMap[OperationHandle, Operation]](this,
"handleToOperation")
- val sessionToActivePool = Map[SessionHandle, String]()
- val sessionToContexts = Map[SessionHandle, SQLContext]()
+ val sessionToActivePool = new ConcurrentHashMap[SessionHandle, String]()
--- End diff --
It's only `private[thriftserver]`. It's minor, and a whole lot of stuff in
Spark that should be `private` isn't, but I wondered if it was worth it here
because you're concerned with synchronizing access to this object and therefore
possibly concerned with what is accessing it. The usages you changed look like
they're sufficiently protected, but are there others BTW?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
