GitHub user cloud-fan opened a pull request:
https://github.com/apache/spark/pull/14562
[SPARK-16973][SQL] remove the buffer offsets in ImperativeAggregate
## What changes were proposed in this pull request?
the `mutableAggBufferOffset` and `inputAggBufferOffset` in
`ImperativeAggregate` are really hard to understand and tightly coupled with
aggregation implementation. What's worse, all `ImperativeAggregate`
implementations need to understand this concept and deal with it carefully.
This PR isolate this buffet offsets concept into the base class
`ImperativeAggregate`, by introducing a sliced row. Then all
`ImperativeAggregate` implementations don't need to care about it anymore.
## How was this patch tested?
existing tests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/cloud-fan/spark agg-minor
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/14562.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #14562
----
commit 9658056f420fc4280cc5ac656e7d45fc28a262de
Author: Wenchen Fan <[email protected]>
Date: 2016-08-08T06:34:22Z
remove the buffer offsets in ImperativeAggregate
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
