Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14567#discussion_r74098782
  
    --- Diff: python/pyspark/context.py ---
    @@ -22,22 +22,30 @@
     import signal
     import sys
     import threading
    -from threading import RLock
     from tempfile import NamedTemporaryFile
    +from threading import RLock
     
     from pyspark import accumulators
     from pyspark.accumulators import Accumulator
     from pyspark.broadcast import Broadcast
     from pyspark.conf import SparkConf
     from pyspark.files import SparkFiles
     from pyspark.java_gateway import launch_gateway
    -from pyspark.serializers import PickleSerializer, BatchedSerializer, 
UTF8Deserializer, \
    -    PairDeserializer, AutoBatchedSerializer, NoOpSerializer
    -from pyspark.storagelevel import StorageLevel
    -from pyspark.rdd import RDD, _load_from_socket, ignore_unicode_prefix
    -from pyspark.traceback_utils import CallSite, first_spark_call
    +from pyspark.profiler import BasicProfiler
    +from pyspark.profiler import ProfilerCollector
    +from pyspark.rdd import RDD
    +from pyspark.rdd import _load_from_socket
    +from pyspark.rdd import ignore_unicode_prefix
    +from pyspark.serializers import AutoBatchedSerializer
    --- End diff --
    
    Expanding these multiple imports seems counter-productive. We don't do it 
in Scala (and in Java you can only import one thing or everything). Is this 
important/canonical for PEP8?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to