Github user junyangq commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14558#discussion_r74171283
  
    --- Diff: R/pkg/R/generics.R ---
    @@ -1046,8 +1084,8 @@ setGeneric("ntile", function(x) { 
standardGeneric("ntile") })
     #' @export
     setGeneric("n_distinct", function(x, ...) { standardGeneric("n_distinct") 
})
     
    -#' @rdname percent_rank
    -#' @export
    +# @rdname percent_rank
    --- End diff --
    
    This is perhaps not the best way, but I did this because otherwise the 
generated doc will show `percent_rank(x)`. Then we have to document `x`, which 
could be confusing to the user since this argument should be left missing in 
actual function call. 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to