Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14155#discussion_r74184724
--- Diff:
sql/core/src/test/scala/org/apache/spark/sql/execution/command/DDLSuite.scala
---
@@ -93,7 +92,7 @@ class DDLSuite extends QueryTest with SharedSQLContext
with BeforeAndAfterEach {
.add("col2", "string")
.add("a", "int")
.add("b", "int"),
- provider = Some("parquet"),
+ provider = Some("hive"),
--- End diff --
Actually it was a mistake. This suite needs to test `set location` or
something which is only valid for hive tables. However, previously we only set
the provider name in provider field, but not the table properties. Then in the
commands we will mistakenly treat it as hive table and won't throw exception.
Now the hive hacks are all moved to external catalog, so setting provider
name in provider field is enough. And we need to use `hive` for hive tables.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
