Github user GraceH commented on a diff in the pull request:
https://github.com/apache/spark/pull/14559#discussion_r74188842
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/DataFrameWriter.scala ---
@@ -447,7 +447,11 @@ final class DataFrameWriter[T] private[sql](ds:
Dataset[T]) {
// Create the table if the table didn't exist.
if (!tableExists) {
val schema = JdbcUtils.schemaString(df, url)
- val sql = s"CREATE TABLE $table ($schema)"
+ // To allow certain options to append when create a new table,
which can be
+ // table_options or partition_options.
+ // E.g., "CREATE TABLE t (name string) ENGINE=InnoDB DEFAULT
CHARSET=utf8"
+ val createtblOptions =
extraOptions.getOrElse("createTableOptions", "")
--- End diff --
A quick question here. The JDBCOptions also contain URL and table
information, like:
```
// a JDBC URL
val url = parameters.getOrElse("url", sys.error("Option 'url' not
specified"))
// name of table
val table = parameters.getOrElse("dbtable", sys.error("Option 'dbtable'
not specified"))
```
Shall we merge those information into current DataFrameWriter as well?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
