Github user hvanhovell commented on a diff in the pull request:
https://github.com/apache/spark/pull/14546#discussion_r74214115
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -1252,7 +1252,9 @@ class Analyzer(
case ae: AnalysisException => filter
}
- case sort @ Sort(sortOrder, global, aggregate: Aggregate) if
aggregate.resolved =>
+ case sort @ Sort(sortOrder, global, aggregate: Aggregate) if
aggregate.resolved &&
+ (conf.orderByOrdinal && sortOrder.forall(x =>
IntegerIndex.unapply(x.child).isEmpty)) =>
--- End diff --
I have the feeling that this guard is wrong. This disables this entire
clause if `conf.orderByOrdinal` is `false`. Shouldn't it be:
`!conf.orderByOrdinal || sortOrder.forall(x =>
IntegerIndex.unapply(x.child).isEmpty)`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
