Github user liancheng commented on a diff in the pull request:
https://github.com/apache/spark/pull/1919#discussion_r16347194
--- Diff:
sql/hive/src/main/scala/org/apache/spark/sql/hive/execution/InsertIntoHiveTable.scala
---
@@ -191,7 +257,10 @@ case class InsertIntoHiveTable(
val outputData = new Array[Any](fieldOIs.length)
iter.map { row =>
var i = 0
- while (i < row.length) {
+ while (i < fieldOIs.length) {
+ if (fieldOIs.length < row.length && row.length - fieldOIs.length
== dynamicPartNum) {
--- End diff --
Sorry, too many comments for a single line :)
Just realized this line is on the critical path, please forget about the
assertion I mentioned above. To avoid unnecessary computations and branches,
I'd suggest something like:
```scala
if (dynamicPartNum > 0) {
iter.map {
// With DP
}
} else {
iter.map {
// Without DP
}
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
