Github user hvanhovell commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14548#discussion_r74427941
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/subquery.scala ---
    @@ -17,42 +17,77 @@
     
     package org.apache.spark.sql.execution
     
    +import scala.collection.mutable
    +import scala.collection.mutable.ArrayBuffer
    +
     import org.apache.spark.sql.SparkSession
    -import org.apache.spark.sql.catalyst.expressions
    -import org.apache.spark.sql.catalyst.InternalRow
    -import org.apache.spark.sql.catalyst.expressions.{Expression, ExprId, 
Literal, SubqueryExpression}
    +import org.apache.spark.sql.catalyst.{expressions, InternalRow}
    +import org.apache.spark.sql.catalyst.expressions._
     import org.apache.spark.sql.catalyst.expressions.codegen.{CodegenContext, 
ExprCode}
     import org.apache.spark.sql.catalyst.plans.logical.LogicalPlan
     import org.apache.spark.sql.catalyst.rules.Rule
    -import org.apache.spark.sql.types.DataType
    +import org.apache.spark.sql.internal.SQLConf
    +import org.apache.spark.sql.types.{BooleanType, DataType, StructType}
    +
    +/**
    + * The base class for subquery that is used in SparkPlan.
    + */
    +trait ExecSubqueryExpression extends SubqueryExpression {
    +
    +  val executedPlan: SubqueryExec
    +  def withExecutedPlan(plan: SubqueryExec): ExecSubqueryExpression
    +
    +  // does not have logical plan
    +  override def query: LogicalPlan = throw new UnsupportedOperationException
    +  override def withNewPlan(plan: LogicalPlan): SubqueryExpression =
    --- End diff --
    
    Ok, lets address this in a (potential) follow-up.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to