Github user felixcheung commented on a diff in the pull request:

    https://github.com/apache/spark/pull/14384#discussion_r74527216
  
    --- Diff: R/pkg/R/mllib.R ---
    @@ -632,3 +642,159 @@ setMethod("predict", signature(object = 
"AFTSurvivalRegressionModel"),
               function(object, newData) {
                 return(dataFrame(callJMethod(object@jobj, "transform", 
newData@sdf)))
               })
    +
    +
    +#' Alternating Least Squares (ALS) for Collaborative Filtering
    +#'
    +#' \code{spark.als} learns latent factors in collaborative filtering via 
alternating least
    +#' squares. Users can call \code{summary} to obtain fitted latent factors, 
\code{predict}
    +#' to make predictions on new data, and \code{write.ml}/\code{read.ml} to 
save/load fitted models.
    +#'
    +#' For more details, see
    +#' 
\href{http://spark.apache.org/docs/latest/ml-collaborative-filtering.html}{MLlib:
    +#' Collaborative Filtering}.
    +#' Additional arguments can be passed to the methods.
    +#' \describe{
    +#'    \item{nonnegative}{logical value indicating whether to apply 
nonnegativity constraints.
    +#'                       Default: FALSE}
    +#'    \item{implicitPrefs}{logical value indicating whether to use 
implicit preference.
    +#'                         Default: FALSE}
    +#'    \item{alpha}{alpha parameter in the implicit preference formulation 
(>= 0). Default: 1.0}
    +#'    \item{seed}{integer seed for random number generation. Default: 0}
    +#'    \item{numUserBlocks}{number of user blocks used to parallelize 
computation (> 0).
    +#'                         Default: 10}
    +#'    \item{numItemBlocks}{number of item blocks used to parallelize 
computation (> 0).
    +#'                         Default: 10}
    +#'    \item{checkpointInterval}{number of checkpoint intervals (>= 1) or 
disable checkpoint (-1).
    +#'                              Default: 10}
    +#'    }
    +#'
    +#' @param data A SparkDataFrame for training
    +#' @param ratingCol column name for ratings
    +#' @param userCol column name for user ids. Ids must be (or can be coerced 
into) integers
    +#' @param itemCol column name for item ids. Ids must be (or can be coerced 
into) integers
    +#' @param rank rank of the matrix factorization (> 0)
    +#' @param reg regularization parameter (>= 0)
    +#' @param maxIter maximum number of iterations (>= 0)
    --- End diff --
    
    please add documentation for `...` as for example `@param ... additional 
name arguments such as nonnegative`


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to