Github user pwendell commented on the pull request:
https://github.com/apache/spark/pull/1813#issuecomment-52549981
Hey Marcelo,
I took a look through this - I also discussed in some detail with @srowen
this past weekend. If we want to fix this problem using shading in our build,
this seems like as good a way as any to do it. It does substantially increase
the complexity of the build which is not great, so maybe longer term we could
consider moving towards just publishing a shaded version of guava upstream.
Regarding this specific implementation, I noticed there is a lot of effort
to mirror this logic in the sbt build. I wonder if maybe we should just leave
this out of the sbt build entirely to reduce the complexiy and in the sbt build
simply have guava be a compile time dependency like it was before. We've said
in the past that our official reference build for packagers is maven, so I
think it's fine if some of the more esoteric build configurations do not exist
in sbt.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
