Github user mpjlu commented on the issue:
https://github.com/apache/spark/pull/14597
Hi @avulanov . In general, FPR feature selection should not modify the
code of existing ChiSqSelector, as we have implemented in this PR. But if we
need to reuse the ChiSqTestResult (Statistics.chiSqTest(data)), it is better
to modify the code of ChiSqSelector.
In Scikit-learn, for each SelectKBest, SelectFpr, SelectPercentile and so
on, create an object for it, as we implemented in this PR. The good point of
this method is it is consistent across the LIB, all use the same
Estimator/Model style. The disadvantage is it cannot reuse the results of
score function. @srowen
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
