Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/14524#discussion_r74780485
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/api/python/PythonMLLibAPI.scala ---
@@ -126,13 +126,15 @@ private[python] class PythonMLLibAPI extends
Serializable {
k: Int,
maxIterations: Int,
minDivisibleClusterSize: Double,
- seed: Long): BisectingKMeansModel = {
- new BisectingKMeans()
+ seed: java.lang.Long): BisectingKMeansModel = {
--- End diff --
To complete the thought here: I discovered that most of the Pyspark API
methods accepted a `java.lang.Long`, in order to only optionally accept a seed.
A few did not however. I also made those consistent, so that the Pyspark
default of seed=None results in a null to this argument, which results in a
default seed in the JVM, which means a random seed.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
