Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14656#discussion_r74882826
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveTableValuedFunctions.scala
---
@@ -0,0 +1,115 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.sql.catalyst.analysis
+
+import org.apache.spark.{SparkConf, SparkContext}
+import org.apache.spark.sql.catalyst.plans._
+import org.apache.spark.sql.catalyst.plans.logical.{LogicalPlan, Range}
+import org.apache.spark.sql.catalyst.rules._
+
+/**
+ * Rule that resolves table-valued function references.
+ */
+object ResolveTableValuedFunctions extends Rule[LogicalPlan] {
+ private lazy val defaultParallelism =
+ SparkContext.getOrCreate(new SparkConf(false)).defaultParallelism
+
+ /**
+ * List of argument names and their types, used to declare a function.
+ */
+ private case class ArgumentList(args: (String, Class[_])*) {
+ /**
+ * @return whether this list is assignable from the given sequence of
values.
+ */
+ def assignableFrom(values: Seq[Any]): Boolean = {
+ if (args.length == values.length) {
+ args.zip(values).forall { case ((name, clazz), value) =>
+ clazz.isAssignableFrom(value.getClass)
+ }
+ } else {
+ false
+ }
+ }
+
+ override def toString: String = {
+ args.map { a =>
+ s"${a._1}: ${a._2.getSimpleName}"
+ }.mkString(", ")
+ }
+ }
+
+ /**
+ * A TVF maps argument lists to resolver functions that accept those
arguments. Using a map
+ * here allows for function overloading.
+ */
+ private type TVF = Map[ArgumentList, Seq[Any] => LogicalPlan]
+
+ /**
+ * Internal registry of table-valued functions. TODO(ekl) we should have
a proper registry
+ */
+ private val builtinFunctions: Map[String, TVF] = Map(
--- End diff --
So I think the catalyst way to do this is that the resolution rule only
works if all the children of the expression is resolved, and then you have a
checkanalysis rule that shows the error if there is an
UnresolvedTableValuedFunction
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
