Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14648#discussion_r74947367
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
---
@@ -727,6 +727,19 @@ object FoldablePropagation extends Rule[LogicalPlan] {
case j @ Join(_, _, LeftOuter | RightOuter | FullOuter, _) =>
stop = true
j
+
+ // Operators that operate on objects should only have expressions
from encoders, which
+ // should never have foldable expressions.
+ case o: ObjectConsumer =>
+ stop = true
+ o
+ case o: ObjectProducer =>
+ stop = true
+ o
+ case a: AppendColumns =>
--- End diff --
After think about it more, I think the foldable propagation is still useful
for object operators like `DeserializeToObject`, how about we specify the
problematic cases here explicitly? i.e. `MapGroups`, `FlatMapGroupsInR`,
`CoGroup`
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
