Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/14657#discussion_r74992037
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/CheckAnalysis.scala
---
@@ -141,7 +141,7 @@ trait CheckAnalysis extends PredicateHelper {
// Skip projects and subquery aliases added by the Analyzer
and the SQLBuilder.
def cleanQuery(p: LogicalPlan): LogicalPlan = p match {
- case SubqueryAlias(_, child) => cleanQuery(child)
+ case SubqueryAlias(_, child, _) => cleanQuery(child)
--- End diff --
not that big of a deal, but wouldn't it be easier and more robust if we
just do
```
case s: SubqueryAlias => cleanQuery(s.child)
case p: Project => cleanQuery(p.child)
case child => child
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
