GitHub user HyukjinKwon opened a pull request:

    https://github.com/apache/spark/pull/14677

    [MINOR][DOC] Fix the descriptions for `properties` argument in the 
documenation for jdbc APIs

    ## What changes were proposed in this pull request?
    
    This should be credited to @mvervuurt. The main purpose of this PR is
     - simply to include the change for the same instance in `DataFrameReader` 
just to match up.
     - just avoid duplicately verifying the PR (as I already did).
    
    The documentation for both should be the same because both assume the 
`properties` should be  the same `dict`.
    
    ## How was this patch tested?
    
    Manually building Python documentation.
    
    This will produce the output as below:
    
    - `DataFrameReader`
    
    ![2016-08-17 11 12 
00](https://cloud.githubusercontent.com/assets/6477701/17722764/b3f6568e-646f-11e6-8b75-4fb672f3f366.png)
    
    - `DataFrameWriter`
    
    ![2016-08-17 11 12 
10](https://cloud.githubusercontent.com/assets/6477701/17722765/b58cb308-646f-11e6-841a-32f19800d139.png)
    
    Closes #14624


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/HyukjinKwon/spark typo-python

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14677.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14677
    
----
commit b0864ecb51a28452f6e33f4bdcd30795c7c2ec99
Author: mvervuurt <[email protected]>
Date:   2016-08-12T18:42:40Z

    Fix docstring of method jdbc of PySpark DataFrameWriter because a 
dictionary of JDBC connection arguments is used instead of a list.

commit f5018616eee50544c22432c2256c75325b537e82
Author: hyukjinkwon <[email protected]>
Date:   2016-08-17T02:17:48Z

    Fix the descriptions for `properties` argument in the documenation for jdbc 
APIs

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to