Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/14562#discussion_r75076293
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/aggregate/HyperLogLogPlusPlus.scala
---
@@ -142,23 +129,16 @@ case class HyperLogLogPlusPlus(
override def inputTypes: Seq[AbstractDataType] = Seq(AnyDataType)
- override def aggBufferSchema: StructType =
StructType.fromAttributes(aggBufferAttributes)
-
/** Allocate enough words to store all registers. */
- override val aggBufferAttributes: Seq[AttributeReference] =
Seq.tabulate(numWords) { i =>
- AttributeReference(s"MS[$i]", LongType)()
- }
-
- // Note: although this simply copies aggBufferAttributes, this common
code can not be placed
- // in the superclass because that will lead to initialization ordering
issues.
--- End diff --
finally get rid of it!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
